Subversion Repositories Kolibri OS

Rev

Rev 1126 | Rev 1179 | Go to most recent revision | Details | Compare with Previous | Last modification | View Log | RSS feed

Rev Author Line No. Line
1123 serge 1
/*
2
 * Copyright 2007-8 Advanced Micro Devices, Inc.
3
 * Copyright 2008 Red Hat Inc.
4
 *
5
 * Permission is hereby granted, free of charge, to any person obtaining a
6
 * copy of this software and associated documentation files (the "Software"),
7
 * to deal in the Software without restriction, including without limitation
8
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9
 * and/or sell copies of the Software, and to permit persons to whom the
10
 * Software is furnished to do so, subject to the following conditions:
11
 *
12
 * The above copyright notice and this permission notice shall be included in
13
 * all copies or substantial portions of the Software.
14
 *
15
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
18
 * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
19
 * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
20
 * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
21
 * OTHER DEALINGS IN THE SOFTWARE.
22
 *
23
 * Authors: Dave Airlie
24
 *          Alex Deucher
25
 */
26
#include "drmP.h"
1126 serge 27
#include "drm_edid.h"
1123 serge 28
#include "drm_crtc_helper.h"
29
#include "radeon_drm.h"
30
#include "radeon.h"
31
 
32
extern void
33
radeon_combios_connected_scratch_regs(struct drm_connector *connector,
34
				      struct drm_encoder *encoder,
35
				      bool connected);
36
extern void
37
radeon_atombios_connected_scratch_regs(struct drm_connector *connector,
38
				       struct drm_encoder *encoder,
39
				       bool connected);
40
 
41
static void
42
radeon_connector_update_scratch_regs(struct drm_connector *connector, enum drm_connector_status status)
43
{
44
	struct drm_device *dev = connector->dev;
45
	struct radeon_device *rdev = dev->dev_private;
46
	struct drm_encoder *best_encoder = NULL;
47
	struct drm_encoder *encoder = NULL;
48
	struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
49
	struct drm_mode_object *obj;
50
	bool connected;
51
	int i;
52
 
53
	best_encoder = connector_funcs->best_encoder(connector);
54
 
55
	for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
56
		if (connector->encoder_ids[i] == 0)
57
			break;
58
 
59
		obj = drm_mode_object_find(connector->dev,
60
					   connector->encoder_ids[i],
61
					   DRM_MODE_OBJECT_ENCODER);
62
		if (!obj)
63
			continue;
64
 
65
		encoder = obj_to_encoder(obj);
66
 
67
		if ((encoder == best_encoder) && (status == connector_status_connected))
68
			connected = true;
69
		else
70
			connected = false;
71
 
72
		if (rdev->is_atom_bios)
73
			radeon_atombios_connected_scratch_regs(connector, encoder, connected);
74
		else
75
			radeon_combios_connected_scratch_regs(connector, encoder, connected);
76
 
77
	}
78
}
79
 
80
struct drm_encoder *radeon_best_single_encoder(struct drm_connector *connector)
81
{
82
	int enc_id = connector->encoder_ids[0];
83
	struct drm_mode_object *obj;
84
	struct drm_encoder *encoder;
85
 
1126 serge 86
    ENTRY();
87
 
1123 serge 88
	/* pick the encoder ids */
89
	if (enc_id) {
90
		obj = drm_mode_object_find(connector->dev, enc_id, DRM_MODE_OBJECT_ENCODER);
91
		if (!obj)
92
			return NULL;
93
		encoder = obj_to_encoder(obj);
94
		return encoder;
95
	}
96
	return NULL;
97
}
98
 
99
static struct drm_display_mode *radeon_fp_native_mode(struct drm_encoder *encoder)
100
{
101
	struct drm_device *dev = encoder->dev;
102
	struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
103
	struct drm_display_mode *mode = NULL;
104
	struct radeon_native_mode *native_mode = &radeon_encoder->native_mode;
105
 
106
	if (native_mode->panel_xres != 0 &&
107
	    native_mode->panel_yres != 0 &&
108
	    native_mode->dotclock != 0) {
109
		mode = drm_mode_create(dev);
110
 
111
		mode->hdisplay = native_mode->panel_xres;
112
		mode->vdisplay = native_mode->panel_yres;
113
 
114
		mode->htotal = mode->hdisplay + native_mode->hblank;
115
		mode->hsync_start = mode->hdisplay + native_mode->hoverplus;
116
		mode->hsync_end = mode->hsync_start + native_mode->hsync_width;
117
		mode->vtotal = mode->vdisplay + native_mode->vblank;
118
		mode->vsync_start = mode->vdisplay + native_mode->voverplus;
119
		mode->vsync_end = mode->vsync_start + native_mode->vsync_width;
120
		mode->clock = native_mode->dotclock;
121
		mode->flags = 0;
122
 
123
		mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;
124
		drm_mode_set_name(mode);
125
 
126
		DRM_DEBUG("Adding native panel mode %s\n", mode->name);
127
	}
128
	return mode;
129
}
130
 
131
int radeon_connector_set_property(struct drm_connector *connector, struct drm_property *property,
132
				  uint64_t val)
133
{
134
	return 0;
135
}
136
 
137
 
138
static int radeon_lvds_get_modes(struct drm_connector *connector)
139
{
140
	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
141
	struct drm_encoder *encoder;
142
	int ret = 0;
143
	struct drm_display_mode *mode;
144
 
145
	if (radeon_connector->ddc_bus) {
146
		ret = radeon_ddc_get_modes(radeon_connector);
147
		if (ret > 0) {
148
			return ret;
149
		}
150
	}
151
 
152
	encoder = radeon_best_single_encoder(connector);
153
	if (!encoder)
154
		return 0;
155
 
156
	/* we have no EDID modes */
157
	mode = radeon_fp_native_mode(encoder);
158
	if (mode) {
159
		ret = 1;
160
		drm_mode_probed_add(connector, mode);
161
	}
162
	return ret;
163
}
164
 
165
static int radeon_lvds_mode_valid(struct drm_connector *connector,
166
				  struct drm_display_mode *mode)
167
{
168
	return MODE_OK;
169
}
170
 
171
static enum drm_connector_status radeon_lvds_detect(struct drm_connector *connector)
172
{
173
	enum drm_connector_status ret = connector_status_connected;
174
	/* check acpi lid status ??? */
175
	radeon_connector_update_scratch_regs(connector, ret);
176
	return ret;
177
}
178
 
179
static void radeon_connector_destroy(struct drm_connector *connector)
180
{
181
	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
182
 
183
	if (radeon_connector->ddc_bus)
184
		radeon_i2c_destroy(radeon_connector->ddc_bus);
185
	kfree(radeon_connector->con_priv);
186
  // drm_sysfs_connector_remove(connector);
187
	drm_connector_cleanup(connector);
188
	kfree(connector);
189
}
190
 
191
struct drm_connector_helper_funcs radeon_lvds_connector_helper_funcs = {
192
	.get_modes = radeon_lvds_get_modes,
193
	.mode_valid = radeon_lvds_mode_valid,
194
	.best_encoder = radeon_best_single_encoder,
195
};
196
 
197
struct drm_connector_funcs radeon_lvds_connector_funcs = {
198
	.dpms = drm_helper_connector_dpms,
199
	.detect = radeon_lvds_detect,
200
	.fill_modes = drm_helper_probe_single_connector_modes,
201
	.destroy = radeon_connector_destroy,
202
	.set_property = radeon_connector_set_property,
203
};
204
 
205
static int radeon_vga_get_modes(struct drm_connector *connector)
206
{
207
	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
208
	int ret;
209
 
210
	ret = radeon_ddc_get_modes(radeon_connector);
211
 
212
	return ret;
213
}
214
 
215
static int radeon_vga_mode_valid(struct drm_connector *connector,
216
				  struct drm_display_mode *mode)
217
{
218
 
219
	return MODE_OK;
220
}
221
 
222
static enum drm_connector_status radeon_vga_detect(struct drm_connector *connector)
223
{
224
	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
225
	struct drm_encoder *encoder;
226
	struct drm_encoder_helper_funcs *encoder_funcs;
227
	bool dret;
228
	enum drm_connector_status ret = connector_status_disconnected;
229
 
230
	radeon_i2c_do_lock(radeon_connector, 1);
231
	dret = radeon_ddc_probe(radeon_connector);
232
	radeon_i2c_do_lock(radeon_connector, 0);
233
	if (dret)
234
		ret = connector_status_connected;
235
	else {
236
		/* if EDID fails to a load detect */
237
		encoder = radeon_best_single_encoder(connector);
238
		if (!encoder)
239
			ret = connector_status_disconnected;
240
		else {
241
			encoder_funcs = encoder->helper_private;
242
			ret = encoder_funcs->detect(encoder, connector);
243
		}
244
	}
245
 
246
	radeon_connector_update_scratch_regs(connector, ret);
247
	return ret;
248
}
249
 
250
struct drm_connector_helper_funcs radeon_vga_connector_helper_funcs = {
251
	.get_modes = radeon_vga_get_modes,
252
	.mode_valid = radeon_vga_mode_valid,
253
	.best_encoder = radeon_best_single_encoder,
254
};
255
 
256
struct drm_connector_funcs radeon_vga_connector_funcs = {
257
	.dpms = drm_helper_connector_dpms,
258
	.detect = radeon_vga_detect,
259
	.fill_modes = drm_helper_probe_single_connector_modes,
260
	.destroy = radeon_connector_destroy,
261
	.set_property = radeon_connector_set_property,
262
};
263
 
264
static int radeon_dvi_get_modes(struct drm_connector *connector)
265
{
266
	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
267
	int ret;
268
 
269
	ret = radeon_ddc_get_modes(radeon_connector);
270
	/* reset scratch regs here since radeon_dvi_detect doesn't check digital bit */
271
	radeon_connector_update_scratch_regs(connector, connector_status_connected);
272
	return ret;
273
}
274
 
275
static enum drm_connector_status radeon_dvi_detect(struct drm_connector *connector)
276
{
277
	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
278
	struct drm_encoder *encoder;
279
	struct drm_encoder_helper_funcs *encoder_funcs;
280
	struct drm_mode_object *obj;
281
	int i;
282
	enum drm_connector_status ret = connector_status_disconnected;
283
	bool dret;
284
 
285
	radeon_i2c_do_lock(radeon_connector, 1);
286
	dret = radeon_ddc_probe(radeon_connector);
287
	radeon_i2c_do_lock(radeon_connector, 0);
288
	if (dret)
289
		ret = connector_status_connected;
290
	else {
291
		for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
292
			if (connector->encoder_ids[i] == 0)
293
				break;
294
 
295
			obj = drm_mode_object_find(connector->dev,
296
						   connector->encoder_ids[i],
297
						   DRM_MODE_OBJECT_ENCODER);
298
			if (!obj)
299
				continue;
300
 
301
			encoder = obj_to_encoder(obj);
302
 
303
			encoder_funcs = encoder->helper_private;
304
			if (encoder_funcs->detect) {
305
				ret = encoder_funcs->detect(encoder, connector);
306
				if (ret == connector_status_connected) {
307
					radeon_connector->use_digital = 0;
308
					break;
309
				}
310
			}
311
		}
312
	}
313
 
314
	/* updated in get modes as well since we need to know if it's analog or digital */
315
	radeon_connector_update_scratch_regs(connector, ret);
316
	return ret;
317
}
318
 
319
/* okay need to be smart in here about which encoder to pick */
320
struct drm_encoder *radeon_dvi_encoder(struct drm_connector *connector)
321
{
322
	int enc_id = connector->encoder_ids[0];
323
	struct radeon_connector *radeon_connector = to_radeon_connector(connector);
324
	struct drm_mode_object *obj;
325
	struct drm_encoder *encoder;
326
	int i;
1126 serge 327
 
328
    ENTRY();
329
 
1123 serge 330
	for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
331
		if (connector->encoder_ids[i] == 0)
332
			break;
333
 
334
		obj = drm_mode_object_find(connector->dev, connector->encoder_ids[i], DRM_MODE_OBJECT_ENCODER);
335
		if (!obj)
336
			continue;
337
 
338
		encoder = obj_to_encoder(obj);
339
 
340
		if (radeon_connector->use_digital) {
341
			if (encoder->encoder_type == DRM_MODE_ENCODER_TMDS)
342
				return encoder;
343
		} else {
344
			if (encoder->encoder_type == DRM_MODE_ENCODER_DAC ||
345
			    encoder->encoder_type == DRM_MODE_ENCODER_TVDAC)
346
				return encoder;
347
		}
348
	}
349
 
350
	/* see if we have a default encoder  TODO */
351
 
352
	/* then check use digitial */
353
	/* pick the first one */
354
	if (enc_id) {
355
		obj = drm_mode_object_find(connector->dev, enc_id, DRM_MODE_OBJECT_ENCODER);
356
		if (!obj)
357
			return NULL;
358
		encoder = obj_to_encoder(obj);
359
		return encoder;
360
	}
361
	return NULL;
362
}
363
 
364
struct drm_connector_helper_funcs radeon_dvi_connector_helper_funcs = {
365
	.get_modes = radeon_dvi_get_modes,
366
	.mode_valid = radeon_vga_mode_valid,
367
	.best_encoder = radeon_dvi_encoder,
368
};
369
 
370
struct drm_connector_funcs radeon_dvi_connector_funcs = {
371
	.dpms = drm_helper_connector_dpms,
372
	.detect = radeon_dvi_detect,
373
	.fill_modes = drm_helper_probe_single_connector_modes,
374
	.set_property = radeon_connector_set_property,
375
	.destroy = radeon_connector_destroy,
376
};
377
 
378
void
379
radeon_add_atom_connector(struct drm_device *dev,
380
			  uint32_t connector_id,
381
			  uint32_t supported_device,
382
			  int connector_type,
383
			  struct radeon_i2c_bus_rec *i2c_bus,
384
			  bool linkb,
385
			  uint32_t igp_lane_info)
386
{
387
	struct drm_connector *connector;
388
	struct radeon_connector *radeon_connector;
389
	struct radeon_connector_atom_dig *radeon_dig_connector;
390
	uint32_t subpixel_order = SubPixelNone;
391
 
392
	/* fixme - tv/cv/din */
393
	if ((connector_type == DRM_MODE_CONNECTOR_Unknown) ||
394
	    (connector_type == DRM_MODE_CONNECTOR_SVIDEO) ||
395
	    (connector_type == DRM_MODE_CONNECTOR_Composite) ||
396
	    (connector_type == DRM_MODE_CONNECTOR_9PinDIN))
397
		return;
398
 
399
	/* see if we already added it */
400
	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
401
		radeon_connector = to_radeon_connector(connector);
402
		if (radeon_connector->connector_id == connector_id) {
403
			radeon_connector->devices |= supported_device;
404
			return;
405
		}
406
	}
407
 
408
	radeon_connector = kzalloc(sizeof(struct radeon_connector), GFP_KERNEL);
409
	if (!radeon_connector)
410
		return;
411
 
412
	connector = &radeon_connector->base;
413
 
414
	radeon_connector->connector_id = connector_id;
415
	radeon_connector->devices = supported_device;
416
	switch (connector_type) {
417
	case DRM_MODE_CONNECTOR_VGA:
418
		drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
419
		drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
420
		if (i2c_bus->valid) {
421
			radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "VGA");
422
			if (!radeon_connector->ddc_bus)
423
				goto failed;
424
		}
425
		break;
426
	case DRM_MODE_CONNECTOR_DVIA:
427
		drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
428
		drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
429
		if (i2c_bus->valid) {
430
			radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "DVI");
431
			if (!radeon_connector->ddc_bus)
432
				goto failed;
433
		}
434
		break;
435
	case DRM_MODE_CONNECTOR_DVII:
436
	case DRM_MODE_CONNECTOR_DVID:
437
		radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
438
		if (!radeon_dig_connector)
439
			goto failed;
440
		radeon_dig_connector->linkb = linkb;
441
		radeon_dig_connector->igp_lane_info = igp_lane_info;
442
		radeon_connector->con_priv = radeon_dig_connector;
443
		drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
444
		drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
445
		if (i2c_bus->valid) {
446
			radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "DVI");
447
			if (!radeon_connector->ddc_bus)
448
				goto failed;
449
		}
450
		subpixel_order = SubPixelHorizontalRGB;
451
		break;
452
	case DRM_MODE_CONNECTOR_HDMIA:
453
	case DRM_MODE_CONNECTOR_HDMIB:
454
		radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
455
		if (!radeon_dig_connector)
456
			goto failed;
457
		radeon_dig_connector->linkb = linkb;
458
		radeon_dig_connector->igp_lane_info = igp_lane_info;
459
		radeon_connector->con_priv = radeon_dig_connector;
460
		drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
461
		drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
462
		if (i2c_bus->valid) {
463
			radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "HDMI");
464
			if (!radeon_connector->ddc_bus)
465
				goto failed;
466
		}
467
		subpixel_order = SubPixelHorizontalRGB;
468
		break;
469
	case DRM_MODE_CONNECTOR_DisplayPort:
470
		radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
471
		if (!radeon_dig_connector)
472
			goto failed;
473
		radeon_dig_connector->linkb = linkb;
474
		radeon_dig_connector->igp_lane_info = igp_lane_info;
475
		radeon_connector->con_priv = radeon_dig_connector;
476
		drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
477
		drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
478
		if (i2c_bus->valid) {
479
			radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "DP");
480
			if (!radeon_connector->ddc_bus)
481
				goto failed;
482
		}
483
		subpixel_order = SubPixelHorizontalRGB;
484
		break;
485
	case DRM_MODE_CONNECTOR_SVIDEO:
486
	case DRM_MODE_CONNECTOR_Composite:
487
	case DRM_MODE_CONNECTOR_9PinDIN:
488
		break;
489
	case DRM_MODE_CONNECTOR_LVDS:
490
		radeon_dig_connector = kzalloc(sizeof(struct radeon_connector_atom_dig), GFP_KERNEL);
491
		if (!radeon_dig_connector)
492
			goto failed;
493
		radeon_dig_connector->linkb = linkb;
494
		radeon_dig_connector->igp_lane_info = igp_lane_info;
495
		radeon_connector->con_priv = radeon_dig_connector;
496
		drm_connector_init(dev, &radeon_connector->base, &radeon_lvds_connector_funcs, connector_type);
497
		drm_connector_helper_add(&radeon_connector->base, &radeon_lvds_connector_helper_funcs);
498
		if (i2c_bus->valid) {
499
			radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "LVDS");
500
			if (!radeon_connector->ddc_bus)
501
				goto failed;
502
		}
503
		subpixel_order = SubPixelHorizontalRGB;
504
		break;
505
	}
506
 
507
	connector->display_info.subpixel_order = subpixel_order;
508
 //  drm_sysfs_connector_add(connector);
509
	return;
510
 
511
failed:
512
	if (radeon_connector->ddc_bus)
513
		radeon_i2c_destroy(radeon_connector->ddc_bus);
514
	drm_connector_cleanup(connector);
515
	kfree(connector);
516
}
517
 
518
void
519
radeon_add_legacy_connector(struct drm_device *dev,
520
			    uint32_t connector_id,
521
			    uint32_t supported_device,
522
			    int connector_type,
523
			    struct radeon_i2c_bus_rec *i2c_bus)
524
{
525
	struct drm_connector *connector;
526
	struct radeon_connector *radeon_connector;
527
	uint32_t subpixel_order = SubPixelNone;
528
 
529
	/* fixme - tv/cv/din */
530
	if ((connector_type == DRM_MODE_CONNECTOR_Unknown) ||
531
	    (connector_type == DRM_MODE_CONNECTOR_SVIDEO) ||
532
	    (connector_type == DRM_MODE_CONNECTOR_Composite) ||
533
	    (connector_type == DRM_MODE_CONNECTOR_9PinDIN))
534
		return;
535
 
536
	/* see if we already added it */
537
	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
538
		radeon_connector = to_radeon_connector(connector);
539
		if (radeon_connector->connector_id == connector_id) {
540
			radeon_connector->devices |= supported_device;
541
			return;
542
		}
543
	}
544
 
545
	radeon_connector = kzalloc(sizeof(struct radeon_connector), GFP_KERNEL);
546
	if (!radeon_connector)
547
		return;
548
 
549
	connector = &radeon_connector->base;
550
 
551
	radeon_connector->connector_id = connector_id;
552
	radeon_connector->devices = supported_device;
553
	switch (connector_type) {
554
	case DRM_MODE_CONNECTOR_VGA:
555
		drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
556
		drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
557
		if (i2c_bus->valid) {
558
			radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "VGA");
559
			if (!radeon_connector->ddc_bus)
560
				goto failed;
561
		}
562
		break;
563
	case DRM_MODE_CONNECTOR_DVIA:
564
		drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
565
		drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
566
		if (i2c_bus->valid) {
567
			radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "DVI");
568
			if (!radeon_connector->ddc_bus)
569
				goto failed;
570
		}
571
		break;
572
	case DRM_MODE_CONNECTOR_DVII:
573
	case DRM_MODE_CONNECTOR_DVID:
574
		drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
575
		drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
576
		if (i2c_bus->valid) {
577
			radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "DVI");
578
			if (!radeon_connector->ddc_bus)
579
				goto failed;
580
		}
581
		subpixel_order = SubPixelHorizontalRGB;
582
		break;
583
	case DRM_MODE_CONNECTOR_SVIDEO:
584
	case DRM_MODE_CONNECTOR_Composite:
585
	case DRM_MODE_CONNECTOR_9PinDIN:
586
		break;
587
	case DRM_MODE_CONNECTOR_LVDS:
588
		drm_connector_init(dev, &radeon_connector->base, &radeon_lvds_connector_funcs, connector_type);
589
		drm_connector_helper_add(&radeon_connector->base, &radeon_lvds_connector_helper_funcs);
590
		if (i2c_bus->valid) {
591
			radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "LVDS");
592
			if (!radeon_connector->ddc_bus)
593
				goto failed;
594
		}
595
		subpixel_order = SubPixelHorizontalRGB;
596
		break;
597
	}
598
 
599
	connector->display_info.subpixel_order = subpixel_order;
600
  // drm_sysfs_connector_add(connector);
601
	return;
602
 
603
failed:
604
	if (radeon_connector->ddc_bus)
605
		radeon_i2c_destroy(radeon_connector->ddc_bus);
606
	drm_connector_cleanup(connector);
607
	kfree(connector);
608
}